feat!: rewrite to use cucumber messages #273

daantimmer · 2025-12-18T23:32:17Z

This (internal) rewrite is to make amp-cucumber-cpp-runner cucumber-messages compatible. Both during runtime and during formatting.

This will enable amp-cucumber-cpp-runner to be compatible with other, standalone, formatters.

… compatibility kit

…r to catch errors

…ta, doc-strings, empty, examples-tables and minimal

…ooks-beforeall-error, hooks, hooks-attachment and hooks-conditional compatibility tests

…ation exists

github-actions · 2025-12-18T23:44:33Z

✅⚠️MegaLinter analysis: Success with warnings

Descriptor	Linter	Files	Fixed	Errors	Warnings	Elapsed time
✅ ACTION	actionlint	6		0	0	0.35s
✅ CPP	clang-format	199	0	0	0	1.42s
✅ DOCKERFILE	hadolint	1		0	0	0.32s
✅ JSON	jsonlint	8		0	0	0.16s
✅ JSON	prettier	8	6	0	0	0.51s
⚠️ MARKDOWN	markdownlint	6	3	14	0	0.8s
✅ MARKDOWN	markdown-table-formatter	6	3	0	0	0.29s
✅ REPOSITORY	git_diff	yes		no	no	0.02s
✅ REPOSITORY	grype	yes		no	no	27.83s
✅ REPOSITORY	ls-lint	yes		no	no	0.06s
✅ REPOSITORY	secretlint	yes		no	no	2.29s
✅ REPOSITORY	syft	yes		no	no	1.22s
✅ REPOSITORY	trivy	yes		no	no	5.51s
✅ REPOSITORY	trivy-sbom	yes		no	no	0.12s
✅ REPOSITORY	trufflehog	yes		no	no	2.17s
⚠️ SPELL	lychee	83		1	0	21.67s
✅ YAML	prettier	10	0	0	0	0.53s
✅ YAML	v8r	10		0	0	6.14s
✅ YAML	yamllint	10		0	0	0.36s

Detailed Issues

⚠️ SPELL / lychee - 1 error

[404] https://github.com/yourname/amp-cucumber-cpp-runner.git | Network error: Not Found
📝 Summary
---------------------
🔍 Total..........155
✅ Successful.....154
⏳ Timeouts.........0
🔀 Redirected.......0
👻 Excluded.........0
❓ Unknown..........0
🚫 Errors...........1

Errors in CONTRIBUTING.md
[404] https://github.com/yourname/amp-cucumber-cpp-runner.git | Network error: Not Found

⚠️ MARKDOWN / markdownlint - 14 errors

CHANGELOG.md:26 MD024/no-duplicate-heading Multiple headings with the same content [Context: "Chores"]
CHANGELOG.md:38 MD024/no-duplicate-heading Multiple headings with the same content [Context: "Features"]
CHANGELOG.md:47 MD024/no-duplicate-heading Multiple headings with the same content [Context: "Features"]
CHANGELOG.md:53 MD024/no-duplicate-heading Multiple headings with the same content [Context: "Chores"]
CHANGELOG.md:61 MD024/no-duplicate-heading Multiple headings with the same content [Context: "⚠ BREAKING CHANGES"]
CHANGELOG.md:65 MD024/no-duplicate-heading Multiple headings with the same content [Context: "Features"]
CHANGELOG.md:70 MD024/no-duplicate-heading Multiple headings with the same content [Context: "Bug Fixes"]
CHANGELOG.md:79 MD024/no-duplicate-heading Multiple headings with the same content [Context: "Features"]
CHANGELOG.md:90 MD024/no-duplicate-heading Multiple headings with the same content [Context: "Chores"]
CHANGELOG.md:98 MD024/no-duplicate-heading Multiple headings with the same content [Context: "⚠ BREAKING CHANGES"]
CHANGELOG.md:102 MD024/no-duplicate-heading Multiple headings with the same content [Context: "Features"]
CHANGELOG.md:127 MD024/no-duplicate-heading Multiple headings with the same content [Context: "Bug Fixes"]
CHANGELOG.md:134 MD024/no-duplicate-heading Multiple headings with the same content [Context: "Chores"]
README.md:114 MD040/fenced-code-language Fenced code blocks should have a language specified [Context: "```"]

See detailed reports in MegaLinter artifacts

Your project could benefit from a custom flavor, which would allow you to run only the linters you need, and thus improve runtime performances. (Skip this info by defining FLAVOR_SUGGESTIONS: false)

Documentation: Custom Flavors
Command: npx [email protected] --custom-flavor-setup --custom-flavor-linters ACTION_ACTIONLINT,CPP_CLANG_FORMAT,DOCKERFILE_HADOLINT,JSON_JSONLINT,JSON_PRETTIER,MARKDOWN_MARKDOWNLINT,MARKDOWN_MARKDOWN_TABLE_FORMATTER,REPOSITORY_GIT_DIFF,REPOSITORY_GRYPE,REPOSITORY_LS_LINT,REPOSITORY_SECRETLINT,REPOSITORY_SYFT,REPOSITORY_TRIVY,REPOSITORY_TRIVY_SBOM,REPOSITORY_TRUFFLEHOG,SPELL_LYCHEE,YAML_PRETTIER,YAML_YAMLLINT,YAML_V8R

github-actions · 2025-12-18T23:51:59Z

Test Results

26 tests 26 ✅ 13s ⏱️
1 suites 0 💤
1 files 0 ❌

Results for commit 7f51629.

♻️ This comment has been updated with latest results.

…s for output

…and simplify trim function

Copilot

Pull request overview

Copilot reviewed 291 out of 417 changed files in this pull request and generated no new comments.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

…in PrettyFormatter

… flow

Copilot

Pull request overview

Copilot reviewed 291 out of 420 changed files in this pull request and generated no new comments.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

github-actions · 2026-01-19T15:51:44Z

.vscode/launch.json

[MegaLinter] _{reported by reviewdog 🐶}

amp-cucumber-cpp-runner/.vscode/launch.json

Lines 8 to 36 in c99c357

"id": "tag",

"description": "Enter the tag to run",

"type": "pickString",

"options": [

"@smoke",

"@rule1 or @smoke",

"@keyword-asterisk",

"@result:UNDEFINED",

"@result:FAILED",

"@result:OK",

"@fail_feature",

"@ex:2",

"@substep",

"@table_argument",

"@thishasarule",

"@nested_steps"

]

},

{

"id": "features",

"description": "Enter the tag to run",

"type": "pickString",

"options": [

"cucumber_cpp/example/features",

"cucumber_cpp/example/features/rule.feature",

"cucumber_cpp/example/features/substep.feature",

"cucumber_cpp/acceptance_test/features",

"cucumber_cpp/devkit/empty/features"

]

github-actions · 2026-01-19T15:51:44Z

.vscode/launch.json

[MegaLinter] _{reported by reviewdog 🐶}

amp-cucumber-cpp-runner/.vscode/launch.json

Lines 38 to 39 in c99c357

],

"configurations": [

github-actions · 2026-01-19T15:51:45Z

.vscode/launch.json

[MegaLinter] _{reported by reviewdog 🐶}

amp-cucumber-cpp-runner/.vscode/launch.json

Lines 41 to 74 in c99c357

"name": "(gdb) Launch",

"type": "cppdbg",

"request": "launch",

"program": "${command:cmake.launchTargetPath}",

"args": [

"--com",

"COMx",

"--nordic",

"--format",

"summary",

"pretty",

"--tags",

"${input:tag}",

"--",

"${input:features}"

],

"stopAtEntry": false,

"cwd": "${workspaceFolder}",

"environment": [

{

"name": "ASAN_OPTIONS",

"value": "detect_leaks=0"

}

],

"externalConsole": false,

"MIMode": "gdb",

"setupCommands": [

{

"description": "Enable pretty-printing for gdb",

"text": "-enable-pretty-printing",

"ignoreFailures": true

}

]

},

github-actions · 2026-01-19T15:51:46Z

.vscode/launch.json

[MegaLinter] _{reported by reviewdog 🐶}

amp-cucumber-cpp-runner/.vscode/launch.json

Lines 76 to 101 in c99c357

"name": "(gdb) Launch - no tags",

"type": "cppdbg",

"request": "launch",

"program": "${command:cmake.launchTargetPath}",

"args": [

"--com",

"COMx",

"--nordic",

"--format",

"summary",

"--",

"${input:features}"

],

"stopAtEntry": false,

"cwd": "${workspaceFolder}",

"environment": [],

"externalConsole": false,

"MIMode": "gdb",

"setupCommands": [

{

"description": "Enable pretty-printing for gdb",

"text": "-enable-pretty-printing",

"ignoreFailures": true

}

]

},

…sive file search

…CLI options

Copilot

Pull request overview

Copilot reviewed 291 out of 420 changed files in this pull request and generated 2 comments.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copilot · 2026-01-19T22:57:59Z

cucumber_cpp/library/engine/test/TestStep.cpp

+    // TEST_F(TestStep, ProvidesAccessToTable)
+    // {
+    //     ASSERT_THAT(step.table[0][0].As<std::string>(), testing::Eq(table[0][0].As<std::string>()));
+    //     ASSERT_THAT(step.table[1][1].As<std::string>(), testing::Eq(table[1][1].As<std::string>()));
+    // }



Commented-out test code should either be removed or uncommented with a TODO explaining why it's temporarily disabled. Dead code increases maintenance burden.

Suggested change

// TEST_F(TestStep, ProvidesAccessToTable)

// {

// ASSERT_THAT(step.table[0][0].As<std::string>(), testing::Eq(table[0][0].As<std::string>()));

// ASSERT_THAT(step.table[1][1].As<std::string>(), testing::Eq(table[1][1].As<std::string>()));

// }

cucumber_cpp/library/Application.cpp

sonarqubecloud · 2026-01-19T23:15:48Z

Quality Gate passed

Issues
127 New issues
7 Accepted issues

Measures
0 Security Hotspots
81.5% Coverage on New Code
0.4% Duplication on New Code

See analysis details on SonarQube Cloud

… better output

Copilot

Pull request overview

Copilot reviewed 291 out of 425 changed files in this pull request and generated no new comments.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

…ror handling

…ne includes

Copilot

Pull request overview

Copilot reviewed 291 out of 425 changed files in this pull request and generated no new comments.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

daantimmer added 22 commits December 8, 2025 12:44

feat!: rewrite to use cucumber messages

1457b95

enable ccache

e8e9362

disable the build of shared libs

792332e

disable position independent code generation for jbeder/yaml-cpp

e8c96aa

add additional launch tags

48d99c6

add first version (empty, minimal and data-tables are enabled) of the…

1ae9468

… compatibility kit

refactored a lot of code

10137be

removed unused files

7ac6e9c

update devcontainers for CI

77b4762

removed agauniyal/rang from dependencies

50a2bce

cleanup Application

4054607

sanitize and dump actual and expected json

45a4380

set option variables for dependencies as cache variables

958e05c

fix grouping for string parameter

6eb2da0

use ScopedFakeTestPartResultReporter instead of EmptyTestEventListene…

ece0b62

…r to catch errors

Enable the following compatibility tests: ambiguous, backgrounds, cda…

6f1f4c8

…ta, doc-strings, empty, examples-tables and minimal

add examples-tables-attachment compatibility test

07a77d7

add attachments compatibility test

028dcc5

enabled examples-tables-undefined and global-hooks compatibility test

640986f

Added global-hooks-afterall-error, global-hooks-attachments, global-h…

cbb2f0c

…ooks-beforeall-error, hooks, hooks-attachment and hooks-conditional compatibility tests

add all compatibility checks by default regardless if a cpp implement…

dfe7157

…ation exists

add hooks-named, hooks-skipped and hooks-undefined compatibility tests

de2aaeb

daantimmer mentioned this pull request Dec 18, 2025

feat: ndjson reporting #240

Closed

15 tasks

daantimmer added 2 commits December 18, 2025 23:40

add multiple-features and multiple-features-reverses compatibility tests

d1a3e52

Merge branch 'main' into feature/rewrite-to-use-cucumber-messages

cad1bcf

daantimmer added 3 commits December 19, 2025 09:46

fix clang-msvc build

83c6e5a

fix clang-msvc build

13484a5

fix MSVC build

c7ee029

daantimmer added 3 commits January 18, 2026 23:42

fix: update launch configuration to use 'summary' and 'pretty' format…

f6ef4df

…s for output

refactor: simplify IndentString implementation using fmt library

6780053

refactor: replace std::format with fmt library for string formatting …

128be72

…and simplify trim function

Copilot AI review requested due to automatic review settings January 18, 2026 23:53

Copilot AI reviewed Jan 18, 2026

View reviewed changes

daantimmer and others added 2 commits January 18, 2026 23:55

refactor: replace std::format with fmt library for string formatting …

607b1af

…in PrettyFormatter

feat: implement nested steps functionality and enhance step execution…

c99c357

… flow

Copilot AI review requested due to automatic review settings January 19, 2026 15:49

Copilot AI reviewed Jan 19, 2026

View reviewed changes

github-actions bot reviewed Jan 19, 2026

View reviewed changes

daantimmer added 3 commits January 19, 2026 22:22

feat: enhance acceptance tests and update Application class for recur…

6d7a37e

…sive file search

fix: correct spelling of 'language' in CLI option description

f07be6d

feat: add configuration dumping option and update default values for …

7f51629

…CLI options

Copilot AI review requested due to automatic review settings January 19, 2026 22:57

Copilot AI reviewed Jan 19, 2026

View reviewed changes

daantimmer and others added 2 commits January 20, 2026 15:09

enable proper theming for PrettyFormatter

bf667b3

feat: add support for ambiguous steps and enhance PrettyFormatter for…

2f359f4

… better output

Copilot AI review requested due to automatic review settings January 20, 2026 23:33

Copilot AI reviewed Jan 20, 2026

View reviewed changes

daantimmer added 4 commits January 21, 2026 00:02

feat: update FindLocationOf to return optional location for better er…

366d9d2

…ror handling

feat: refactor PrettyFormatter to improve error handling and streamli…

1dff606

…ne includes

feat: enhance sanitizer options for better memory error detection

2dc68e0

feat: enhance PrettyFormatter to include feature and rule line options

49fd5f5

Copilot AI review requested due to automatic review settings January 21, 2026 00:12

Copilot AI reviewed Jan 21, 2026

View reviewed changes

feat: add logging for running features with specified tags

320e3d2

	"id": "tag",
	"description": "Enter the tag to run",
	"type": "pickString",
	"options": [
	"@smoke",
	"@rule1 or @smoke",
	"@keyword-asterisk",
	"@result:UNDEFINED",
	"@result:FAILED",
	"@result:OK",
	"@fail_feature",
	"@ex:2",
	"@substep",
	"@table_argument",
	"@thishasarule",
	"@nested_steps"
	]
	},
	{
	"id": "features",
	"description": "Enter the tag to run",
	"type": "pickString",
	"options": [
	"cucumber_cpp/example/features",
	"cucumber_cpp/example/features/rule.feature",
	"cucumber_cpp/example/features/substep.feature",
	"cucumber_cpp/acceptance_test/features",
	"cucumber_cpp/devkit/empty/features"
	]

	"name": "(gdb) Launch",
	"type": "cppdbg",
	"request": "launch",
	"program": "${command:cmake.launchTargetPath}",
	"args": [
	"--com",
	"COMx",
	"--nordic",
	"--format",
	"summary",
	"pretty",
	"--tags",
	"${input:tag}",
	"--",
	"${input:features}"
	],
	"stopAtEntry": false,
	"cwd": "${workspaceFolder}",
	"environment": [
	{
	"name": "ASAN_OPTIONS",
	"value": "detect_leaks=0"
	}
	],
	"externalConsole": false,
	"MIMode": "gdb",
	"setupCommands": [
	{
	"description": "Enable pretty-printing for gdb",
	"text": "-enable-pretty-printing",
	"ignoreFailures": true
	}
	]
	},

	"name": "(gdb) Launch - no tags",
	"type": "cppdbg",
	"request": "launch",
	"program": "${command:cmake.launchTargetPath}",
	"args": [
	"--com",
	"COMx",
	"--nordic",
	"--format",
	"summary",
	"--",
	"${input:features}"
	],
	"stopAtEntry": false,
	"cwd": "${workspaceFolder}",
	"environment": [],
	"externalConsole": false,
	"MIMode": "gdb",
	"setupCommands": [
	{
	"description": "Enable pretty-printing for gdb",
	"text": "-enable-pretty-printing",
	"ignoreFailures": true
	}
	]
	},

feat!: rewrite to use cucumber messages #273

Are you sure you want to change the base?

feat!: rewrite to use cucumber messages #273

Uh oh!

Conversation

daantimmer commented Dec 18, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions bot commented Dec 18, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

✅⚠️MegaLinter analysis: Success with warnings

Detailed Issues

Uh oh!

github-actions bot commented Dec 18, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Test Results

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

github-actions bot Jan 19, 2026

Choose a reason for hiding this comment

Uh oh!

github-actions bot Jan 19, 2026

Choose a reason for hiding this comment

Uh oh!

github-actions bot Jan 19, 2026

Choose a reason for hiding this comment

Uh oh!

github-actions bot Jan 19, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Copilot AI Jan 19, 2026

Choose a reason for hiding this comment

Uh oh!

Uh oh!

sonarqubecloud bot commented Jan 19, 2026

Quality Gate passed

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

daantimmer commented Dec 18, 2025 •

edited

Loading

github-actions bot commented Dec 18, 2025 •

edited

Loading

github-actions bot commented Dec 18, 2025 •

edited

Loading